Make file updates for utility script #2529
Closed
Swetna wants to merge 5 commits into
Closed
Conversation
Collaborator
|
@Swetna Unfortunately, if you opened this off another feature branch that was merged, this will have a merge conflict on the changelog. Could you resolve, making sure the branch starts with an empty file? |
Collaborator
Author
|
Sorry about that I think this should fix it if not I can update the PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
- Coverage 63.62% 62.22% -1.41%
==========================================
Files 56 57 +1
Lines 2161 2417 +256
Branches 287 345 +58
==========================================
+ Hits 1375 1504 +129
- Misses 729 849 +120
- Partials 57 64 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Please redo the PR, this still deletes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the makefile for issue #2408